Skip to content

feat: Clean up verbose logging for better CLI output (PR-03) #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shivasurya merged 1 commit into from
Jan 20, 2026
Merged

feat: Clean up verbose logging for better CLI output (PR-03) #475

shivasurya merged 1 commit into from
Jan 20, 2026
+9 −9

Conversation

@shivasurya
Copy link
Owner

@shivasurya shivasurya commented Jan 20, 2026

Summary

Reorganizes logging levels to reduce noise and improve signal-to-noise ratio. Moves function-level progress messages to debug level and clarifies flag descriptions.

Why this change?

  • Reduce noise: Default output was too verbose with per-function progress messages
  • Better UX: Users get clean, essential information without being overwhelmed
  • Proper semantics: Function-level details belong in debug mode, not verbose mode
  • Clear expectations: Flag descriptions now accurately reflect what each level shows

Changes

  • Move 5 function-level Progress() calls to Debug() in callgraph builder:
    • "Extracting return types..."
    • "Extracting variable assignments..."
    • "Extracting class attributes..."
    • "Resolving call sites..."
    • "Generating taint summaries..."
  • Update --verbose flag description: "Show statistics and timing information"
  • Update --debug flag description: "Show detailed debug diagnostics with file-level progress and timestamps"
  • Maintain all existing functionality, just reorganize verbosity levels

Behavior Changes

Before:

--verbose: Shows progress + statistics + function-level details
--debug: Shows progress + statistics + function-level details + timestamps

After:

--verbose: Shows statistics and timing only (clean)
--debug: Shows everything including function-level details + timestamps

Testing

  • All existing tests pass
  • Manual verification of output at each verbosity level
  • No functional changes, purely organizational

Stack

  • Depends on: PR-02 (Progress bars)
  • Part of CLI Output Enhancement initiative (PR-03 of 4)

🤖 Generated with Claude Code

@shivasurya shivasurya added the enhancement New feature or request label Jan 20, 2026
@shivasurya shivasurya self-assigned this Jan 20, 2026
@safedep
Copy link

safedep bot commented Jan 20, 2026 •
edited
Loading

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

This report is generated by SafeDep Github App

@codecov
Copy link

codecov bot commented Jan 20, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.97%. Comparing base (3d99b86) to head (950b150).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   79.97%   79.97%           
=======================================
  Files         101      101           
  Lines       11114    11114           
=======================================
  Hits         8888     8888           
  Misses       1874     1874           
  Partials      352      352

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shivasurya shivasurya mentioned this pull request Jan 20, 2026
Merged
@shivasurya Graphite App
Copy link
Owner Author

shivasurya commented Jan 20, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 20, 2026
Merged
Merged
@shivasurya Graphite App
Copy link
Owner Author

shivasurya commented Jan 20, 2026 •
edited
Loading

Merge activity

  • Jan 20, 3:40 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 20, 3:44 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jan 20, 3:45 AM UTC: @shivasurya merged this pull request with Graphite.

@shivasurya shivasurya changed the base branch from feature/cli-progress-bars-pr02 to graphite-base/475 January 20, 2026 03:41
@shivasurya shivasurya changed the base branch from graphite-base/475 to main January 20, 2026 03:43
@shivasurya @claude
feat: Clean up verbose logging for better CLI output (PR-03)
950b150 
Implements Phase 1 - Step 3 (Final) of CLI Output Enhancement by moving granular
logging to debug level, allowing progress bars to provide visual feedback instead.

Modified files:
- graph/callgraph/builder/builder.go: Move 5 function-level Progress() calls to Debug()
  - Extracting return types from modules
  - Extracting variable assignments
  - Extracting class attributes
  - Resolving call sites
  - Generating taint summaries
- cmd/scan.go: Update --verbose and --debug flag descriptions
- cmd/ci.go: Update --verbose and --debug flag descriptions

Flag description changes:
- --verbose: "Show progress and statistics" → "Show statistics and timing information"
- --debug: "Show debug diagnostics with timestamps" → "Show detailed debug diagnostics with file-level progress and timestamps"

Rationale:
- With progress bars from PR-02, function-level logging is too granular for verbose mode
- Progress bars now show visual feedback: "Building callgraph", "Executing rules"
- Debug mode still shows all detailed function-by-function progress
- Users get cleaner output in default and verbose modes
- Debug mode provides comprehensive troubleshooting information

This completes the 3-phase CLI Output Enhancement:
- PR-01: Banner system and TTY detection
- PR-02: Progress bars for major operations
- PR-03: Logging level cleanup (this PR)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
@shivasurya shivasurya force-pushed the feature/cli-logging-cleanup-pr03 branch from 9f28f72 to 950b150 Compare January 20, 2026 03:44
@shivasurya shivasurya merged commit 2b8e9fc into main Jan 20, 2026
5 checks passed
@shivasurya shivasurya deleted the feature/cli-logging-cleanup-pr03 branch January 20, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@shivasurya shivasurya

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shivasurya